Updated benchmark runner script #207
Closed
+50
−102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
randerzander
approved these changes
Apr 23, 2021
VibhuJawa
reviewed
Apr 23, 2021
| cd $GPU_BDB_HOME/gpu_bdb/queries/q$qnum/ | ||
| for j in $(seq 1 $N_REPEATS) | ||
| do | ||
| python gpu_bdb_query_$qnum\_sql.py --config_file ../../benchmark_runner/benchmark_config.yaml |
There was a problem hiding this comment.
Just noting that launching a process for each script will add library import-related overheads which for 30 queries quickly add up for the whole benchmark.
IIRC they add to like 30-50s of the whole run time which is significant
There was a problem hiding this comment.
This is a good point, and something I had forgotten. Let's discuss this more offline
|
Closing as this this no longer relevant after many recent changes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
We switched to using Python for the benchmark runner initially because we ran into errors related to library interactions, import order, and namespace visibility across nodes. At this point, we should longer need any special consideration.
There is some implicitly duplicated configuration (
INCLUDE_BLAZINGin addition to a configuration argument in thebenchmark_config.yamlfile, GPU_BDB_HOME, etc.), but this will be addressed in a follow-up that restructures a bit more broadly.